fix: connection URL with custom base path, update Kotlin to 1.5.10#227
Merged
fix: connection URL with custom base path, update Kotlin to 1.5.10#227
Conversation
bednar
force-pushed
the
fix/connection-url
branch
from
9aef4df to
6fff1ed
Compare
bednar
force-pushed
the
fix/connection-url
branch
from
6fff1ed to
4458153
Compare
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
============================================
+ Coverage 89.16% 89.18% +0.01%
Complexity 442 442
============================================
Files 143 143
Lines 5696 5706 +10
Branches 269 270 +1
============================================
+ Hits 5079 5089 +10
Misses 538 538
Partials 79 79
Continue to review full report at Codecov.
|
bednar
force-pushed
the
fix/connection-url
branch
from
4458153 to
3b7f734
Compare
rhajek
approved these changes
Jun 11, 2021
| String serverURL = String.format("http://%s:%d", mockServer.url("").host(), mockServer.url("").port()); | ||
|
|
||
| String[][] connectionStrings = { | ||
| // http://localhost:8086/influxDB/ -> http://localhost:8086/influxDB/api/v2/query |
Contributor
There was a problem hiding this comment.
Can you verify that url parsing is working also for URL without explicitly specified port ? Like https://us-west-2-1.aws.cloud2.influxdata.com/ ?
Contributor
Author
There was a problem hiding this comment.
Verification for Cloud:
bednar
changed the title
Contributor
Author
rhajek
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
Proposed Changes
Supports URL specified like:
Updated Kotlin due the compatibility with JDK 16:
Checklist
mvn testcompletes successfully