feat: Apache Karaf support#221
Merged
bednar merged 4 commits intoinfluxdata:masterfrom Apr 15, 2021
borcsokj:feat/karaf-support
Merged
feat: Apache Karaf support#221bednar merged 4 commits intoinfluxdata:masterfrom borcsokj:feat/karaf-support
bednar merged 4 commits intoinfluxdata:masterfrom
borcsokj:feat/karaf-support
Conversation
Contributor
|
Thanks again for your PR 👍 , let's first finish #220... |
Contributor
bednar
requested changes
Apr 14, 2021
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thanks again for your awesome PR 👍... There is a few requirements that should be satisfy before we accept the PR:
- Apply following git patch that will add
karafmodule into CircleCI caching strategy:- circleci_patch.txt
git apply circleci_patch.txt
and a few following requirements in code:
Contributor
Author
|
@bednar, thanks for your review, I applied changes you wrote. |
bednar
approved these changes
Apr 15, 2021
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thanks again for your PR 👍... We are ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219
Proposed Changes
Apache Karaf support (depends on #220 )
Checklist
mvn testcompletes successfully