Skip to content

feat(flux-dsl): allow to specify name of column in last function#216

Merged
bednar merged 2 commits intomasterfrom
flux/last-column
Apr 9, 2021
Merged

feat(flux-dsl): allow to specify name of column in last function#216
bednar merged 2 commits intomasterfrom
flux/last-column

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Apr 8, 2021 •
edited
Loading

Closes #215

Proposed Changes

Allow queries like:

Flux flux = Flux
    .from("telegraf")
    .last("_time");

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar changed the title feat(flux-dsl): allow to specify column in last function feat(flux-dsl): allow to specify name of column in last function Apr 8, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #216 (5288fae) into master (5be7b5f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
+ Coverage     88.39%   88.40%   +0.01%     
- Complexity      447      449       +2     
============================================
  Files           139      139              
  Lines          5516     5521       +5     
  Branches        227      227              
============================================
+ Hits           4876     4881       +5     
  Misses          561      561              
  Partials         79       79
Impacted Files Coverage Δ Complexity Δ
...dsl/src/main/java/com/influxdb/query/dsl/Flux.java 96.12% <100.00%> (+0.02%) 144.00 <1.00> (+1.00)
...ava/com/influxdb/query/dsl/functions/LastFlux.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7b5f...5288fae. Read the comment docs.

@bednar bednar marked this pull request as ready for review April 8, 2021 05:47
@bednar bednar requested a review from rhajek April 8, 2021 05:47
@bednar bednar mentioned this pull request Apr 8, 2021
Closed
@bednar bednar merged commit 570f33a into master Apr 9, 2021
@bednar bednar deleted the flux/last-column branch April 9, 2021 06:03
@bednar bednar added this to the 2.2.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

Add supporting column parameter for last function(flux-dsl)

3 participants

@bednar @codecov-io @rhajek