Skip to content

fix: Remove org.json dependency#197

Merged
bednar merged 5 commits intomasterfrom
remove-java-json
Feb 9, 2021
Merged

fix: Remove org.json dependency#197
bednar merged 5 commits intomasterfrom
remove-java-json

Conversation

@rhajek
Copy link
Copy Markdown
Contributor

@rhajek rhajek commented Feb 3, 2021 •
edited
Loading

Closes #196

Proposed Changes

Remove badly licenced org.json library and relace it with gson.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 3, 2021 •
edited
Loading

Codecov Report

Merging #197 (de35b9a) into master (02039ed) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
- Coverage     89.29%   89.28%   -0.01%     
  Complexity      447      447              
============================================
  Files           139      139              
  Lines          5453     5452       -1     
  Branches        214      215       +1     
============================================
- Hits           4869     4868       -1     
  Misses          507      507              
  Partials         77       77
Impacted Files Coverage Δ Complexity Δ
.../java/com/influxdb/exceptions/InfluxException.java 97.91% <100.00%> (+0.09%) 0.00 <0.00> (ø)
...n/java/com/influxdb/internal/AbstractQueryApi.java 80.76% <100.00%> (-0.72%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02039ed...995e26d. Read the comment docs.

@rhajek rhajek changed the title Remove java json fix: Remove org.json dependency Feb 3, 2021
@rhajek rhajek requested a review from bednar February 3, 2021 16:50
bednar
bednar reviewed Feb 4, 2021
View reviewed changes
Comment thread client-core/src/main/java/com/influxdb/exceptions/InfluxException.java Outdated
Comment thread client-core/src/main/java/com/influxdb/internal/AbstractQueryApi.java Outdated
bednar
bednar approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bednar bednar added this to the 1.16.0 milestone Feb 4, 2021
@bednar bednar merged commit 2d4b877 into master Feb 9, 2021
@bednar bednar deleted the remove-java-json branch February 9, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Licensing issue with JSON-Java library

3 participants

@rhajek @codecov-io @bednar