Skip to content

fix: downgrade gson to 2.8.5 to support Java 8#169

Merged
bednar merged 2 commits intoinfluxdata:masterfrom
jsimomaa:master
Oct 27, 2020
Merged

fix: downgrade gson to 2.8.5 to support Java 8#169
bednar merged 2 commits intoinfluxdata:masterfrom
jsimomaa:master

Conversation

@jsimomaa
Copy link
Copy Markdown
Contributor

@jsimomaa jsimomaa commented Oct 27, 2020

Downgrade gson version from 2.8.6 to 2.8.5 in order to support Java 8.

Related gson issue: google/gson#1608

gson 2.8.7 should fix this once it is released

Closes #

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

Downgrade gson version from 2.8.6 to 2.8.5 in order to support Java 8.

Related gson issue: google/gson#1608

gson 2.8.7 should fix this once it is released
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 27, 2020

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     90.30%   90.30%           
  Complexity      439      439           
=========================================
  Files           138      138           
  Lines          5427     5427           
  Branches        213      213           
=========================================
  Hits           4901     4901           
  Misses          450      450           
  Partials         76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21497dc...00a684f. Read the comment docs.

@bednar bednar self-requested a review October 27, 2020 08:34
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@bednar bednar changed the title Downgrade gson to 2.8.5 to support Java 8 fix: downgrade gson to 2.8.5 to support Java 8 Oct 27, 2020
@bednar bednar added this to the 1.13.0 milestone Oct 27, 2020
@bednar bednar merged commit 9b4fdca into influxdata:master Oct 27, 2020
@bednar bednar added the bug Something isn't working label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants