Skip to content

fix: Offset param could be 0 - FluxDSL#161

Merged
bednar merged 1 commit intomasterfrom
fix/limit-offset
Oct 16, 2020
Merged

fix: Offset param could be 0 - FluxDSL#161
bednar merged 1 commit intomasterfrom
fix/limit-offset

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Oct 7, 2020 •
edited
Loading

Closes #160

Proposed Changes

Offset param could be 0 - FluxDSL

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review October 8, 2020 06:27
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2020

Codecov Report

Merging #161 into master will decrease coverage by 0.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #161      +/-   ##
============================================
- Coverage     91.26%   90.30%   -0.97%     
+ Complexity      843      439     -404     
============================================
  Files           138      138              
  Lines          9792     5427    -4365     
  Branches        414      215     -199     
============================================
- Hits           8937     4901    -4036     
+ Misses          727      450     -277     
+ Partials        128       76      -52
Impacted Files Coverage Δ Complexity Δ
...va/com/influxdb/query/dsl/functions/LimitFlux.java 100.00% <100.00%> (ø) 4.00 <1.00> (-4.00)
...lth/InfluxDB2HealthIndicatorAutoConfiguration.java 0.00% <0.00%> (-92.46%) 0.00% <0.00%> (ø%)
...fluxdb/spring/health/InfluxDB2HealthIndicator.java 0.00% <0.00%> (-82.86%) 0.00% <0.00%> (ø%)
...va/com/influxdb/client/internal/DeleteApiImpl.java 0.00% <0.00%> (-70.67%) 0.00% <0.00%> (ø%)
...com/influxdb/spring/metrics/Influx2Properties.java 24.00% <0.00%> (-58.03%) 3.00% <0.00%> (ø%)
...spring/metrics/Influx2PropertiesConfigAdapter.java 33.33% <0.00%> (-29.94%) 1.00% <0.00%> (ø%)
...com/influxdb/client/internal/TemplatesApiImpl.java 60.00% <0.00%> (-29.26%) 0.00% <0.00%> (ø%)
...om/influxdb/spring/influx/InfluxDB2Properties.java 71.42% <0.00%> (-22.50%) 16.00% <0.00%> (+3.00%) ⬇️
...src/main/java/com/influxdb/client/FindOptions.java 66.66% <0.00%> (-19.91%) 0.00% <0.00%> (ø%)
.../com/influxdb/query/internal/FluxResultMapper.java 51.31% <0.00%> (-16.10%) 0.00% <0.00%> (-10.00%)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b0fca...f3d2fbc. Read the comment docs.

@bednar bednar merged commit b791381 into master Oct 16, 2020
@bednar bednar deleted the fix/limit-offset branch October 16, 2020 13:46
@bednar bednar added this to the 1.13.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

limit offset param maybe is number 0

3 participants

@bednar @codecov-io @rhajek