Skip to content

Support "inf" in Duration#109

Closed
jay-w-opus wants to merge 1 commit intoinfluxdata:masterfrom
jay-w-opus:patch-2
Closed

Support "inf" in Duration#109
jay-w-opus wants to merge 1 commit intoinfluxdata:masterfrom
jay-w-opus:patch-2

Conversation

@jay-w-opus
Copy link
Copy Markdown
Contributor

@jay-w-opus jay-w-opus commented Apr 26, 2020

Closes #

"inf" is required to implement the "aggregateWindow" function manually.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #109 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     90.09%   90.00%   -0.10%     
  Complexity      429      429              
============================================
  Files           136      136              
  Lines          5392     5392              
  Branches        218      218              
============================================
- Hits           4858     4853       -5     
- Misses          446      448       +2     
- Partials         88       91       +3     
Impacted Files Coverage Δ Complexity Δ
...ent-core/src/main/java/com/influxdb/Arguments.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../influxdb/client/internal/AbstractWriteClient.java 89.57% <0.00%> (-1.90%) 0.00% <0.00%> (ø%)
...luxdb/client/kotlin/internal/QueryKotlinApiImpl.kt 76.11% <0.00%> (-1.50%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6101b5...86e277c. Read the comment docs.

@bednar bednar self-requested a review April 27, 2020 07:48
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongjiewu,

thanks for PR. Please, add test into com.influxdb.ArgumentsDurationTest.

Regards

@rolincova
Copy link
Copy Markdown
Contributor

Fixed by #110

@rolincova rolincova closed this May 11, 2020
@bednar bednar added this to the 1.8.0 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants