fix bug caused by typo in "WindowFlux"#108
Merged
bednar merged 2 commits intoinfluxdata:masterfrom Apr 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
============================================
- Coverage 90.09% 90.00% -0.10%
Complexity 429 429
============================================
Files 136 136
Lines 5392 5392
Branches 218 218
============================================
- Hits 4858 4853 -5
- Misses 446 448 +2
- Partials 88 91 +3
Continue to review full report at Codecov.
|
bednar
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
I'm not sure if I miss anything. I was trying to put "offset" into the function but only found "start". However, according to the spec, "start" does not seem to be an acceptable argument, according to https://github.com/influxdata/flux/blob/master/execute/window.go