docs: add warning if there is to much created WriteApi instances

bednar · bednar · commit 6c66806dedc7 · 2021-08-12T15:30:40.000+02:00
diff --git a/client/src/main/java/com/influxdb/client/InfluxDBClient.java b/client/src/main/java/com/influxdb/client/InfluxDBClient.java
@@ -67,6 +67,11 @@ public interface InfluxDBClient extends AutoCloseable {
     /**
      * Create a new asynchronous non-blocking Write client.
      *
+     * <p>
+     * The {@link WriteApi} uses background thread to ingesting data into InfluxDB and is suppose to run as a singleton.
+     * <b>Don't create new instance for every write.</b>
+     * </p>
+     *
      * @deprecated use {@link #makeWriteApi()}, the API is subject to removal in a next major release
      * @return the new client instance for the Write API
      */
diff --git a/client/src/main/java/com/influxdb/client/internal/InfluxDBClientImpl.java b/client/src/main/java/com/influxdb/client/internal/InfluxDBClientImpl.java
@@ -129,9 +129,17 @@ public WriteApi makeWriteApi() {
 
     @Nonnull
     @Override
+    @SuppressWarnings("MagicNumber")
     public WriteApi makeWriteApi(@Nonnull final WriteOptions writeOptions) {
         Arguments.checkNotNull(writeOptions, "WriteOptions");
 
+        if (autoCloseables.size() >= 10) {
+            String format = "There is already created %d instances of 'WriteApi'. "
+                    + "The 'WriteApi' is suppose to run as a singleton and should be reused across threads. "
+                    + "Use 'WriteApiBlocking` if you would like to use one-time ingesting.";
+            LOG.warning(String.format(format, autoCloseables.size()));
+        }
+
         return new WriteApiImpl(writeOptions, retrofit.create(WriteService.class), options, autoCloseables);
     }
 
