Support spring.config.type property #23#35
Conversation
slaskawi
left a comment
slaskawi
left a comment
There was a problem hiding this comment.
Looks good, only some minor things found...
| try { | ||
| conditionContext.getBeanFactory().getBean(InfinispanRemoteConfigurer.class); | ||
| return true; | ||
| } catch (NoSuchBeanDefinitionException e) { |
There was a problem hiding this comment.
It seems most of this is just reformatting changes. Could you please unstage it from commit?
There was a problem hiding this comment.
Yeah, looks like IDEA has reformatted the code (it looks like the code use a mixed format as some files are set to 3 spaces indentation and others 4 spaces), I will fix it.
| }, | ||
| properties = { | ||
| "spring.main.banner-mode=off", | ||
| "spring.cache.type=SIMPLE", |
There was a problem hiding this comment.
This should be set to none to match the assertions.
| InfinispanEmbeddedCacheManagerAutoConfiguration.class | ||
| }, | ||
| properties = { | ||
| "spring.main.banner-mode=off", |
There was a problem hiding this comment.
This one could probably be removed. It adds only noise.
There was a problem hiding this comment.
It is used to avoid spring boot printing its banner during tests, I will move it to application.properties
|
Done |
|
Awesome work! Thanks @lburgazzoli! |
2 participants
No description provided.