Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Create separate starters for embedded and client/server mode #31#34

Merged
slaskawi merged 1 commit intoinfinispan:masterfrom
lburgazzoli:github-31
Jul 5, 2017
Merged

Create separate starters for embedded and client/server mode #31#34
slaskawi merged 1 commit intoinfinispan:masterfrom
lburgazzoli:github-31

Conversation

@lburgazzoli
Copy link
Copy Markdown
Contributor

No description provided.

<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-spring4-remote</artifactId>
<optional>true</optional>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include this one as well? The goal of this split is to get users who use the starters going with minimum manual stuff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean remove optional ?

pom.xml Outdated
<module>infinispan-spring-boot-starter-embedded</module>
<module>infinispan-spring-boot-starter-remote</module>
<module>infinispan-spring-boot-starter</module>
<module>infinispan-spring-boot-starter-test-remote</module>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've done the split, we can squash some impl and test modules like infinispan-spring-boot-starter-remote and infinispan-spring-boot-starter-test-remote.

@slaskawi
Copy link
Copy Markdown
Contributor

slaskawi commented Jul 3, 2017

Thanks a lot for the PR @lburgazzoli! There are only some small things to fix and we are good to go.

@slaskawi
Copy link
Copy Markdown
Contributor

slaskawi commented Jul 3, 2017 via email

@lburgazzoli
Copy link
Copy Markdown
Contributor Author

done:

  • remove optional deps
  • squash tests
  • update docs

<artifactId>spring-boot-configuration-processor</artifactId>
</dependency>

<dependency>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this before, this (core) needs to be removed from the remote starter.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@slaskawi slaskawi merged commit 7fe4fab into infinispan:master Jul 5, 2017
@slaskawi
Copy link
Copy Markdown
Contributor

slaskawi commented Jul 5, 2017

Thanks @lburgazzoli !

@slaskawi
Copy link
Copy Markdown
Contributor

slaskawi commented Jul 5, 2017

I'll test it out with some demos and I think we can release 2.0.0.Alpha1. Good stuff!

@lburgazzoli lburgazzoli deleted the github-31 branch July 6, 2017 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants