This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Auto discovery embedded cache configurations #29#30
Merged
slaskawi merged 1 commit intoinfinispan:masterfrom May 31, 2017
Merged
Auto discovery embedded cache configurations #29#30slaskawi merged 1 commit intoinfinispan:masterfrom
slaskawi merged 1 commit intoinfinispan:masterfrom
Conversation
Contributor
|
Looks good, I like the idea! Could you please enhance your PR by adding two things:
|
Contributor
Author
|
Does the remote cache support multiple configurations ? |
Contributor
|
No no, it supports only 1 configuration. Just look it up and apply if
that's not a problem. Thanks for looking into it!
On Thu, May 25, 2017 at 3:43 PM Luca Burgazzoli ***@***.***> wrote:
Does the remote cache support multiple configurations ?
Or in this case is just to lookup the remote cache configuration and apply
it ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIBvhv-_wESGH4Ups-bpBZG75WbkgpOgks5r9YWPgaJpZM4NmMLM>
.
--
SEBASTIAN ŁASKAWIEC
INFINISPAN DEVELOPER
Red Hat EMEA <https://www.redhat.com/>
<https://red.ht/sig>
|
Contributor
Author
|
Should the InfinispanRemoteConfigurer be deprecated ? It could be nice to add also an InfinispanRemoteConfigrationCustomizer, like: @FunctionalInterface
public interface InfinispanRemoteConfigrationCustomizer {
void configure(final ConfigurationBuilder builder);
}Then the Configuration bean lookup would happen as last step if none of the current steps succeed and finally the customizers are triggered. Make any sense ? |
lburgazzoli
force-pushed
the
cache-configuration
branch
from
ce7a0b4 to
d677446
Compare
Contributor
|
+1, makes sense. |
slaskawi
suggested changes
May 29, 2017
| import infinispan.autoconfigure.common.InfinispanProperties; | ||
|
|
||
| public class InfinispanRemoteCacheManagerChecker implements Condition { | ||
| public static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); |
Contributor
There was a problem hiding this comment.
It seems this logger is not used.
|
|
||
| ### Customization | ||
|
|
||
| You can further customize the cache manager by creating beans of types `InfinispanCacheConfigurer` and/or `InfinispanGlobalConfigurer`. |
Contributor
There was a problem hiding this comment.
For symmetry reasons, I think we should also create customizers (probably both global and per cache). This way everything will be consistent.
README.adoc
Outdated
| [source,java] | ||
| .Example | ||
| ---- | ||
| @Order(Ordered.HIGHEST_PRECEDENCE) |
lburgazzoli
force-pushed
the
cache-configuration
branch
from
d677446 to
e1e62bf
Compare
Contributor
Author
|
I've pushed a new version with requested changes |
slaskawi
approved these changes
May 31, 2017
Contributor
|
Thanks a lot @lburgazzoli! Awesome work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.