Formal Operator configuration design v3#108
Merged
galderz merged 4 commits intoinfinispan:masterfrom Sep 11, 2019
Merged
Conversation
Member
Author
|
For reference, link to formal specification v2 is #77. |
e0d3e17 to
b862490
Compare
6a63695 to
9999137
Compare
Member
Author
|
@ryanemerson @tristantarrant @Crumby Infinispan 10 is already in master and so we'll be moving fast implementing this configuration. So, last chance saloon to review this ;) |
This was referenced Aug 27, 2019
Closed
Closed
9999137 to
91b6e6d
Compare
91b6e6d to
2b0d273
Compare
Member
|
@galderz I would merge this if it's ok to you |
Member
Author
|
@rigazilla Yeah let's merge it |
This was referenced Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3 of the operator configuration design here. Noteworthy changes:
General
.spec.container.jvmOptionsAppendto.spec.container.extraJvmOpts..spec.managementgone.Securedprofile toDefaultprofile.Security
.spec.managementremoved since no separate options are configured for it anymore.credentials,certificate,tokenoroauthtype of authentication..spec.service.container.storage. This has been done because storage is a per-container setting only for data grid service. Adding.containermakes it clear that is per-container, and not a global storage option for all pods to share.X-Site
xsite://...format, where the host:port combination define the static external host:port combination.openshift://...format, where host:port combinations define the dynamic nature of remote openshift instances. Operator will connect remotely and figure out what the external host:port is, and it will configure infinispan with that.credentialsand/ortokento connect to openshift instancesNotes
so not having easy to configure external routes in operator is not a show stopper. More details to come.