Ispn 1797 Implement MongoDB based cache store#1473
Ispn 1797 Implement MongoDB based cache store#1473gscheibel wants to merge 1 commit intoinfinispan:masterfrom
Conversation
cachestore/mongodb/pom.xml
Outdated
There was a problem hiding this comment.
where exactly ? the capital S in the "CacheStore" word
There was a problem hiding this comment.
ohh yes, I read it 3 times and didn't see the typo :)
|
Hi @gscheibel , great steps forward! This looks like almost ready. Could you rebase this all and squash it in a single commit? As I have some minor comments to do yet but it's hard to find where to comment exactly. Then to be really perfectionist, these are the things I'd love you to check:
Could you write up a couple of paragraphs in the Infinispan documentation about how to use it, maybe with an example configuration if you think that could help? |
|
@Sanne I've just perform the code style reformat and the squash, now I get started on the doc |
|
@Sanne I was about to start the documentation on Confluence when I saw an email from Manik about a refactoring of the doc (probably moving to ascii doc). I think I should probably wait the new way of documenting instead of working on Confluence and then have to move to the new way. |
|
It would be great to have it in Confluence first as otherwise it will be delayed a lot. We'll be able to export from Confluence to ascii doc, so hopefully it will only requires some minor style / formatting. Looking forward for the docs :) |
|
@Sanne I don't have the right to add a page into the user guide. Which "workflow" should I follow, I submit a page doc to the team and someone will integrate it ? Should I ask someone (who ?) ? |
|
@gscheibel this would be a great time to finally merge this in Infinispan: 5.2 was released and 5.3 will start release train very soon. |
parent/pom.xml
Outdated
There was a problem hiding this comment.
I see OGM is using version 2.9.0 . Could we use the same?
There was a problem hiding this comment.
The latest version is 2.10.1.
In 2.10.0 they have added a new MongoClient class which replace the Mongo class. By default, the new one connects to the server with a WriteConcern at ACKNOWLEGEMENT. https://jira.mongodb.org/browse/JAVA-682
So should I implement this version (and in OGM as well ?)
There was a problem hiding this comment.
Right in that case I think we should upgrade OGM too, also people will be happy that we will use the same WriteConcern as the driver by default: less confusing.
You choose if you have time to fix OGM first, for me it mostly important that we can keep using the same versions across this module and OGM, or we won't be able to use them together as we'd like to. Of course we won't always be able to keep them perfectly in sync but since you say they changed the API this looks like an urgent concern. Could you start by opening an OGM issue?
/cc @emmanuelbernard
|
@Sanne to activate the mongodb module you need to have MONGODB_HOSTNAME defined just like for OGM. |
7 participants
No description provided.