PHPStan integration: drop --fail-without-result-cache#2429
Merged
Conversation
staabm
changed the title
--fail-without-result-cache
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
maks-rafalko
approved these changes
Oct 7, 2025
maks-rafalko
marked this pull request as ready for review
October 7, 2025 12:15
maks-rafalko
enabled auto-merge (squash)
October 7, 2025 12:15
maks-rafalko
dismissed
github-actions[bot]’s stale review
October 7, 2025 12:15
tests have been updated
maks-rafalko
added
the
TestFramework / PHPstan
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop
--fail-without-result-cachewhich does not work when a project contains PHPStan extension classes and those get mutated. these will not create a cache hit and emit the following warning:background story: see phpstan/phpstan-doctrine#686 (comment) and following