Fixes template of MRTG Backend Config#746
Closed
seadog007 wants to merge 1 commit intoinex:masterfrom
Closed
Conversation
barryo
added a commit
that referenced
this pull request
Nov 13, 2021
Member
|
Hi @seadog007 - thanks for this. If I understand what you're trying to do, I think my version above will work and will sort it at source. Basically: if we have no ifIndex then we've never found the port via SNMP and so we should exclude it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BF] Summary of fix - fixes template of MRTG Backend Config
The original template will cause the backend can't proper generate the graph for switch aggregated / infra / overall after manually adding interface (for example dummy interface).
The MRTG config of the original template will be like
It contains some invalid reference which can't retrieve from the SNMP, eventually cause the graph fail to render.
The quick fix is to check whether or not the interface can be retrieved from the SNMP, to achieve that, the simply way is to check the existence of the return value of ifnameToSNMPIdentifier().
The final MRTG config will be like
In addition to the above, I have:
<?= $t->ee( $data ) ?>or equivalent.