Customer log view displays changes for VLAN with same ID as cust #733
Description
ISSUE TYPE
Bug Report
OS
VERSION
define( 'APPLICATION_VERSION', '6.0.0' );
define( 'APPLICATION_VERDATE', '2021071400' );
ENVIRONMENT
PHP 8.0.9 (cli) (built: Jul 30 2021 13:03:39) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.9, Copyright (c) Zend Technologies
with Zend OPcache v8.0.9, Copyright (c), by Zend Technologies
root@portal:/srv/ixpmanager# dpkg -l | grep php
ii libapache2-mod-php8.0 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (Apache 2 module)
ii php-common 2:84+ubuntu20.04.1+deb.sury.org+1 all Common files for PHP packages
ii php-composer-ca-bundle 1.2.6-1 all utility library to find a path to the system CA bundle
ii php-composer-semver 1.5.1-1 all utilities, version constraint parsing and validation
ii php-composer-spdx-licenses 1.5.3-1 all SPDX licenses list and validation library
ii php-composer-xdebug-handler 1.4.0-1 all Restarts a process without Xdebug
ii php-ds 1.3.0-6+ubuntu20.04.1+deb.sury.org+1 amd64 PHP extension providing efficient data structures for PHP 7
ii php-json-schema 5.2.9-1 all implementation of JSON schema
ii php-memcache 8.0+4.0.5.2+3.0.9~20170802.e702b5f9+-1+ubuntu20.04.1+deb.sury.org+2 amd64 memcache extension module for PHP
ii php-memcached 3.1.5+2.2.0-9+ubuntu20.04.1+deb.sury.org+1 amd64 memcached extension module for PHP, uses libmemcached
ii php-psr-container 1.0.0-2 all Common Container Interface (PHP FIG PSR-11)
ii php-psr-log 1.1.2-1 all common interface for logging libraries
ii php-rrd 2.0.3+1.1.3-1+ubuntu20.04.1+deb.sury.org+1 amd64 PHP bindings to rrd tool system
ii php-symfony-console 4.3.8+dfsg-1ubuntu1 all run tasks from the command line
ii php-symfony-filesystem 4.3.8+dfsg-1ubuntu1 all basic filesystem utilities
ii php-symfony-finder 4.3.8+dfsg-1ubuntu1 all find files and directories
ii php-symfony-process 4.3.8+dfsg-1ubuntu1 all execute commands in sub-processes
ii php-symfony-service-contracts 1.1.8-1 all Generic abstractions related to writing services
ii php-yaml 2.2.1+2.1.0+2.0.4+1.3.2-6+ubuntu20.04.1+deb.sury.org+1 amd64 YAML-1.1 parser and emitter for PHP
ii php8.0 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 all server-side, HTML-embedded scripting language (metapackage)
ii php8.0-bcmath 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 Bcmath module for PHP
ii php8.0-cgi 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (CGI binary)
ii php8.0-cli 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 command-line interpreter for the PHP scripting language
ii php8.0-common 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 documentation, examples and common module for PHP
ii php8.0-curl 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 CURL module for PHP
ii php8.0-ds 1.3.0-6+ubuntu20.04.1+deb.sury.org+1 amd64 PHP extension providing efficient data structures for PHP 7
ii php8.0-fpm 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (FPM-CGI binary)
ii php8.0-gd 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 GD module for PHP
ii php8.0-igbinary 3.2.4+2.0.8-1+ubuntu20.04.1+deb.sury.org+1 amd64 igbinary PHP serializer
ii php8.0-intl 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 Internationalisation module for PHP
ii php8.0-mbstring 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 MBSTRING module for PHP
ii php8.0-memcache 8.0+4.0.5.2+3.0.9~20170802.e702b5f9+-1+ubuntu20.04.1+deb.sury.org+2 amd64 memcache extension module for PHP
ii php8.0-memcached 3.1.5+2.2.0-9+ubuntu20.04.1+deb.sury.org+1 amd64 memcached extension module for PHP, uses libmemcached
ii php8.0-msgpack 2.1.2+0.5.7-6+ubuntu20.04.1+deb.sury.org+1 amd64 PHP extension for interfacing with MessagePack
ii php8.0-mysql 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 MySQL module for PHP
ii php8.0-opcache 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 Zend OpCache module for PHP
ii php8.0-readline 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 readline module for PHP
ii php8.0-rrd 2.0.3+1.1.3-1+ubuntu20.04.1+deb.sury.org+1 amd64 PHP bindings to rrd tool system
ii php8.0-snmp 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 SNMP module for PHP
ii php8.0-xml 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 DOM, SimpleXML, XML, and XSL module for PHP
ii php8.0-yaml 2.2.1+2.1.0+2.0.4+1.3.2-6+ubuntu20.04.1+deb.sury.org+1 amd64 YAML-1.1 parser and emitter for PHP
ii php8.0-zip 8.0.9-1+ubuntu20.04.1+deb.sury.org+1 amd64 Zip module for PHP
SUMMARY
New log feature -- when showing customer log, erroneously displays info about the VLAN which happens to match the customer ID.
From the "View Logs" button top right for customer id = 84
DIsplays also the logs for VLAN id = 84. This VLAN is not related to the customer.
Under the "Details" page "View Logs" buttons:
on "Registration Details" displays the VLAN history if the cust has no log entries matching CompanyRegisteredDetail
Otherwise, if there is a history of changed registration details, it displays correctly (no VLAN history displayed)
Similar behaviour for Billing details change log if there's no entries matching CompanyBillingDetail
STEPS TO REPRODUCE
- Change a VLAN with an ID happening to match a customer ID
- Show logs in customer view as above