Relax libzstd version checking #267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgthegreat
commented
Aug 17, 2025
| unsigned our_hardcoded_version = 10507; | ||
| if (ZSTD_VERSION_NUMBER != our_hardcoded_version || | ||
| zstd_ver_no != our_hardcoded_version) { | ||
| unsigned zstd_version_min = 10506; |
Contributor
Author
There was a problem hiding this comment.
This was changed in 41f6dfa but it does not seem necessary, there are no actual ABI deps on 1.5.7
Contributor
Author
|
@indygreg, could you, please, take a look? |
|
Can anyone watch this PR? |
robot-piglet
pushed a commit
to yandex/yatool
that referenced
this pull request
Sep 8, 2025
Backport of [PR #267](indygreg/python-zstandard#267) from python-zstandard upstream. commit_hash:d20d3652f2ab8ca7a3309abc03f1076c40b84417
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Sep 8, 2025
Backport of [PR #267](indygreg/python-zstandard#267) from python-zstandard upstream. commit_hash:d20d3652f2ab8ca7a3309abc03f1076c40b84417
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Sep 8, 2025
Backport of [PR #267](indygreg/python-zstandard#267) from python-zstandard upstream. commit_hash:d20d3652f2ab8ca7a3309abc03f1076c40b84417
indygreg
approved these changes
Sep 14, 2025
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
This seems reasonable. I'll cherry-pick this locally and close via a push. I'll also add an additional commit to document the new semantics.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254