use Buffer instead of ByteString #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to import |
`ByteString` was [deprecated](https://docs.python.org/3.12/whatsnew/3.12.html#deprecated) in Python 3.12 and [removed](https://docs.python.org/3.14/whatsnew/3.14.html#collections-abc) in 3.14. `collections.abc.Buffer` is available since Python 3.12. Fixes indygreg#238 .
Contributor
Author
|
@ofek it looks like some of the CI tests (macos) are timing out: I've no idea why the anaconda/windows tests are failing, though. pypy/windows tests seem to be failing because of obsolete distutils usage. |
indygreg
approved these changes
Aug 16, 2025
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
Looks good. Thank you for the fix.
I've cherry picked this commit locally and will push to main outside of GitHub. The PR will be marked as closed but in reality it has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteStringwas deprecated in Python 3.12 and removed in 3.14.collections.abc.Bufferis available since Python 3.12.Fixes #238 .