cffi: Use the distutils preprocessor when available #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Unix like systems, distutils will usually set the preprocessor attribute to the appropriate command. On MSVC it never sets the preprocessor, though. In either case, try to use it and only fallback to using the compiler if needed. Using compiler.compiler[0] breaks use of ccache when inserted in the CC environment variable. This is a regression from 0d1329a. Closes indygreg#178.
Contributor
Author
|
Ping? Anything I can do to help get this merged? |
indygreg
approved these changes
Oct 29, 2022
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
This looks good. Thank you for the contribution. And sorry about the delay: I typically only look at this project every few months, as it is reasonably stable.
indygreg
pushed a commit
that referenced
this pull request
Oct 29, 2022
On Unix like systems, distutils will usually set the preprocessor attribute to the appropriate command. On MSVC it never sets the preprocessor, though. In either case, try to use it and only fallback to using the compiler if needed. Using compiler.compiler[0] breaks use of ccache when inserted in the CC environment variable. This is a regression from 0d1329a. Closes #178. Closes #179.
indygreg
pushed a commit
that referenced
this pull request
Oct 29, 2022
On Unix like systems, distutils will usually set the preprocessor attribute to the appropriate command. On MSVC it never sets the preprocessor, though. In either case, try to use it and only fallback to using the compiler if needed. Using compiler.compiler[0] breaks use of ccache when inserted in the CC environment variable. This is a regression from 0d1329a. Closes #178. Closes #179.
Contributor
Author
|
No problem. I'm certainly guilty of letting contributions bitrot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unix like systems, distutils will usually set the preprocessor
attribute to the appropriate command. On MSVC it never sets the
preprocessor, though. In either case, try to use it and only fallback to
using the compiler if needed. Using compiler.compiler[0] breaks use of
ccache when inserted in the CC environment variable.
This is a regression from 0d1329a.
Closes #178.