Skip to content

Closing a ZstdCompressionWriter or ZstdDecompressionWriter should not close underlying file #76

@rtkbkish

Description

@rtkbkish

The changes to support ZstdCompressionWriter and ZstdDecompressionWriter without a context mananger has broken use cases where they are being used in a context manager.

Upon a close, the writers should not close their underlying file objects. It should be up to the caller to close the file objects.

We are passing in StringIO objects to the writers and they get closed upon exit--throwing out the buffer. This technique works with other compression libraries.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions