Repository navigation
Commit d80feec
Fix ISPC code generation for subscripted private temporaries
ExprToISPCExprMapper.map_subscript calls
get_grid_size_upper_bounds_as_exprs() without the callables table, which
has been a required argument since the 2021 kernel callables work. Any
kernel that subscripts a private temporary therefore fails ISPC code
generation with "TypeError: LoopKernel.get_grid_size_upper_bounds_as_exprs()
missing 1 required positional argument: 'callables_table'". That includes
ordinary uses of an "ilp" iname, which privatizes temporaries into arrays.
The other three calls in loopy/target/ispc.py were updated over time
(map_variable in fbdda4d for gh-763, the temporary declarator in
34c7344); this one was missed. Pass self.codegen_state.callables_table,
as map_variable does.
test_ispc_private_array is the subscripted counterpart of
test_ispc_private_var.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 5bd3945 commit d80feec
2 files changed
Lines changed: 25 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
| 172 | + | |
| 173 | + | |
173 | 174 | | |
174 | 175 | | |
175 | 176 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
799 | 799 | | |
800 | 800 | | |
801 | 801 | | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
802 | 825 | | |
803 | 826 | | |
804 | 827 | | |
| |||
0 commit comments