Support scanning custom QR codes from plugins #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
approved these changes
Aug 18, 2025
ThiefMaster
reviewed
Sep 2, 2025
ThiefMaster
reviewed
Sep 2, 2025
ThiefMaster
force-pushed
the
support-custom-qr-codes
branch
from
a2fc3a4 to
30ddcf8
Compare
ThiefMaster
reviewed
Sep 2, 2025
ThiefMaster
reviewed
Sep 3, 2025
ThiefMaster
reviewed
Sep 3, 2025
ThiefMaster
reviewed
Sep 3, 2025
ThiefMaster
reviewed
Sep 3, 2025
Member
|
Once thing that would be nice to have is a list of registered custom qrcode handlers somewhere... but not sure where, since we don't display a server list anywhere. Maybe more something for the future and not for now... |
ThiefMaster
reviewed
Sep 4, 2025
SegiNyn
force-pushed
the
support-custom-qr-codes
branch
from
426604f to
af15843
Compare
ThiefMaster
reviewed
Sep 4, 2025
ThiefMaster
reviewed
Sep 4, 2025
Member
|
Can you log the errors in the two places I commented on? That's the only thing missing to merge this :) |
tomasr8
reviewed
Sep 4, 2025
SegiNyn
commented
Sep 4, 2025
ThiefMaster
reviewed
Sep 4, 2025
ThiefMaster
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow scanning of custom plugin qr-codes.
Associated PR: indico/indico#6954
An example of how to implement the signals to test this PR was included in indico/indico#6954