Optionally store email attachments #7182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
force-pushed
the
feat/download-email-attachments
branch
from
9396fd9 to
f5bade2
Compare
ThiefMaster
reviewed
Nov 30, 2025
moliholy
force-pushed
the
feat/download-email-attachments
branch
from
2018229 to
bc5adc7
Compare
Contributor
Author
|
@ThiefMaster ready for another round! |
Only the `.save()` call can actually fail
ThiefMaster
force-pushed
the
feat/download-email-attachments
branch
from
bc5adc7 to
1584412
Compare
- reuse previously saved file during a single question (e.g. in case of bulk mails that all have the same attachment) - use a uuid instead of the content hash for uniqueness, because otherwise saving a file w/ the same content fails and spams the log w/ errors about that
Also rename the storage-related keys to be more consistent with the rest of Indico
ThiefMaster
approved these changes
Dec 9, 2025
Member
|
I'm not adding a changelog entry for this, because I think it make more sense to add one once there's functionality such as using these files to allow re-sending emails even if they have attachments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
indico.confconfiguration flag to optionally store email attachments in the designated backend.