Add missing SMTP_USE_SSL option #7177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
smpt_use_ssl
branch
2 times, most recently
from
cc7e7d4 to
7fa749d
Compare
ThiefMaster
reviewed
Nov 24, 2025
Comment on lines
+598
to
+600
| Note that the email handler for error log emails is not compatible | ||
| with this setting, so when using it instead of STARTTLS you may want | ||
| to tweak your ``logging.yaml`` to not attempt to send emails. |
Member
There was a problem hiding this comment.
See the code here.
AFAIK the stdlib simply does not support SMTPS for logging. Not much we can do about it. Maybe it's enough to just have it documented next to this setting that it will not work. Ideally people use something like Sentry on bigger deployments anyway...
Member
There was a problem hiding this comment.
After checking the code, stdlib indeed does not support it. So I'm very inclined to indeed just accept that logging emails will not work when using this option.
The smtp backend did support SSL already, just the config option was missing.
ThiefMaster
force-pushed
the
smpt_use_ssl
branch
from
7fa749d to
238b282
Compare
ThiefMaster
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smtp backend did support SSL already, just the config option was missing.
closes #4347