Use field date format in XLSX exports for registrations #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
force-pushed
the
fix-registration-date-export
branch
from
dbf5e26 to
e0fd298
Compare
ThiefMaster
approved these changes
Nov 10, 2025
ThiefMaster
reviewed
Nov 25, 2025
| bold = workbook.add_format({'bold': True}) | ||
| wb_formats = { | ||
| fmt: workbook.add_format({'num_format': _strftime_to_excel_number_format(fmt)}) | ||
| for fmt in {value for value in column_formats.values() if value} |
Member
There was a problem hiding this comment.
This breaks when no column_format are specified... ie in any excel export that's not registrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #6887.
While the registration data is now a Date object in Excel, the configured format doesn’t follow the configured format in the field. For instance, date fields that are configured as YYYY appear in Excel as 2025-01-01.
The PR configures those Date cells in Excel the same format configure in the registration form field. The formats are passed to
send_xlsxvia a new optional argument that takes a mapping of header->format.generate_xlsxthen adds the mappings to the workbook and applies it to the cells of each respective column.Happy Halloween 🎃