Skip to content

Allow review tag editing #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 23 commits into from
Oct 31, 2025
Merged

Allow review tag editing #7134

ThiefMaster merged 23 commits into from
Oct 31, 2025

Conversation

@micsucmed
Copy link
Contributor

@micsucmed micsucmed commented Oct 17, 2025

Closes #7133

@micsucmed micsucmed changed the title Allow review tag editing - front-end Allow review tag editing Oct 22, 2025
@micsucmed micsucmed force-pushed the edit-tags-on-revision branch 2 times, most recently from 6443f9c to 075ea3b Compare October 24, 2025 10:12
@micsucmed micsucmed marked this pull request as ready for review October 24, 2025 10:19
ThiefMaster
ThiefMaster reviewed Oct 24, 2025
View reviewed changes
ThiefMaster
ThiefMaster reviewed Oct 27, 2025
View reviewed changes
@micsucmed micsucmed force-pushed the edit-tags-on-revision branch 2 times, most recently from c9670e0 to dd31e8a Compare October 30, 2025 15:05
@micsucmed micsucmed requested a review from ThiefMaster October 30, 2025 15:07
ThiefMaster
ThiefMaster reviewed Oct 30, 2025
View reviewed changes
@ThiefMaster ThiefMaster force-pushed the edit-tags-on-revision branch from dd31e8a to 58afae8 Compare October 31, 2025 11:36
@ThiefMaster
Remove TODO
8374892
@ThiefMaster
Make edit tooltips consistent
0b270de
@ThiefMaster
Keep edit button visible
60257fc 
I initially did not like it, but the comment edit box does the same so
for the sake of consistency it's actually better to keep it there as
well even though the alignment looks a bit weird...
@ThiefMaster
Remove invalid styleName
39b2b28
@ThiefMaster ThiefMaster enabled auto-merge (squash) October 31, 2025 11:59
@ThiefMaster ThiefMaster added this to the v3.3 milestone Oct 31, 2025
@ThiefMaster ThiefMaster merged commit aa63c9b into indico:master Oct 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

Edit tags on revisions

2 participants

@micsucmed @ThiefMaster