Skip to content

Let admins add emails to users without validation #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 7 commits into from
Nov 24, 2025
Merged

Let admins add emails to users without validation #7116

ThiefMaster merged 7 commits into from
Nov 24, 2025

Conversation

@vasiliyk
Copy link
Contributor

@vasiliyk vasiliyk commented Oct 2, 2025 •
edited by ThiefMaster
Loading

A simple PR to implement #6872. Please let me know if it is ok. Thank you!

  • Make sure your code is complete 🌕:

    • Have you added code comments in parts that are harder to understand?
    • Have you checked that you haven't forgotten to add any newly created files to the Git repo?

  • Make sure that your code has no errors ✅:

    • Code style and formatting - have you run eslint and ruff (or the pre-commit hook)?
    • Regressions - have you tried running the unit tests? (pytest)

  • Make sure others understand what has changed 📢:

    • Log any feature changes and bug fixes in CHANGES.rst (changelog for developers)
    • Update the documentation if needed
    • Check that your commit messages are clear and contain no typos. The subject message should be in the imperative mood;

@ThiefMaster
Copy link
Member

ThiefMaster commented Oct 2, 2025

Thanks for the contribution.

It's a bit unfortunate that you ignored this comment in the issue - it would have been a nice issue for a future member of our development team...

Note: This may be a nice issue for a newcomer in the team since it's limited to a small area of the code and does not require much knowledge about the overall Indico codebase. If you are an outside contributor, please do not pick this for now.

@vasiliyk
Copy link
Contributor Author

vasiliyk commented Oct 2, 2025 •
edited
Loading

I thought it was for newcomers who could be your potential future members.
I am sorry for the misunderstanding!!

ThiefMaster
ThiefMaster reviewed Oct 2, 2025
View reviewed changes
@tomasr8
Copy link
Member

tomasr8 commented Oct 3, 2025

@vasiliyk There are some lint issues, could you sort them out?

@vasiliyk
Copy link
Contributor Author

vasiliyk commented Oct 7, 2025

@ThiefMaster , @tomasr8 should I check anything else to proceed with the PR?

@vasiliyk vasiliyk requested a review from ThiefMaster October 14, 2025 18:37
@ThiefMaster
Copy link
Member

ThiefMaster commented Oct 23, 2025

Hey, I simply did not have the time yet to thoroughly review it, and considering that this is security-sensitive code it's not something I want to rush.

@vasiliyk vasiliyk closed this Nov 24, 2025
@ThiefMaster
Copy link
Member

ThiefMaster commented Nov 24, 2025

Let's keep it open, it's still something we would like to eventually merge.

@ThiefMaster ThiefMaster reopened this Nov 24, 2025
vasiliyk and others added 5 commits November 24, 2025 18:07
@vasiliyk @ThiefMaster
Let admins add emails to users without validation
b490015
@vasiliyk @ThiefMaster
making lenght of lines <=120
e7e9751
@vasiliyk @ThiefMaster
Util method add_secondary_email() added
9fc16b9 
"Admin: skip email validation" checkbox added for admin user
@vasiliyk @ThiefMaster
Lint issues fixed - unused import statements
97e6128
@ThiefMaster
Various improvements
08ec58b 
- fix display issues
- add explanation on the new option
- remove obsolete code from validation
- log skipped validation
@ThiefMaster ThiefMaster added this to the v3.3 milestone Nov 24, 2025
@ThiefMaster ThiefMaster enabled auto-merge (squash) November 24, 2025 18:01
@ThiefMaster ThiefMaster merged commit d0c279b into indico:master Nov 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@vasiliyk @ThiefMaster @tomasr8