Skip to content

Conversation

@tomako
Copy link
Contributor

@tomako tomako commented Oct 1, 2025

This PR is about adding placeholders to the event reminders.

  • They are added only for the custom event reminders
  • It is not allowed to use person-specific placeholders (first name, last name) when email addresses entered manually

@tomako tomako force-pushed the add_placeholders_to_event_reminders branch 2 times, most recently from b549589 to 8ac5f80 Compare October 1, 2025 21:00
@tomako tomako requested a review from ThiefMaster October 1, 2025 21:13
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from 8ac5f80 to 7cb45d5 Compare October 1, 2025 21:21
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from 7cb45d5 to d83dc3b Compare October 2, 2025 14:33
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from d83dc3b to 3812173 Compare October 7, 2025 18:24
@tomako tomako requested a review from ThiefMaster October 7, 2025 18:30
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from 3812173 to 1884a17 Compare October 20, 2025 10:08
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from 1884a17 to 3384c69 Compare November 3, 2025 18:30
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch from 3384c69 to 3f2dfae Compare November 26, 2025 12:28
@tomako tomako force-pushed the add_placeholders_to_event_reminders branch 2 times, most recently from ee044da to d214874 Compare December 8, 2025 16:58
@ThiefMaster ThiefMaster force-pushed the add_placeholders_to_event_reminders branch from 6092cdd to 6c0e3f4 Compare December 9, 2025 12:57
@ThiefMaster ThiefMaster enabled auto-merge (squash) December 9, 2025 13:13
@ThiefMaster ThiefMaster added this to the v3.3 milestone Dec 9, 2025
@ThiefMaster ThiefMaster merged commit 97bef22 into indico:master Dec 9, 2025
10 checks passed
@ThiefMaster
Copy link
Member

FYI I fixed a small bug introduced by this PR: #7238
I didn't spot it when testing because I always used "send immediately' to test, which of course doesn't to through celery so there was a request context...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants