Skip disabled sections for field conditions #7114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
requested review from
GovernmentPlates and
tomasr8
and removed request for
GovernmentPlates
tomasr8
approved these changes
Oct 2, 2025
Member
tomasr8
left a comment
tomasr8
left a comment
There was a problem hiding this comment.
The selector names are a bit confusing (and I guess the cause of this bug).. getFlatSections returns all sections while getSections returns only enabled (and sorted) sections.. maybe we could use more descriptive names?
Member
Author
|
Yeah, it's a chaos. I didn't want to touch that while just fixing a bug reported by a user though, which is why I just added the comment to make it less likely that someone else shoots himself in the foot with that selector. |
GovernmentPlates
approved these changes
Oct 2, 2025
micsucmed
pushed a commit
to micsucmed/indico
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such fields were displayed in the dropdown, and could be saved, which resulted in a broken registration form.