Refactor conference themes #7110
Conversation
|
Nice! Just be aware that many conference organizers provide their own CSS to theme the conference. |
|
However, for further changes to the conference page structure that involves touching the HTML structure etc, you'd need to be very careful about not breaking customizations. If needed I can check our database for certain things. In fact, depending on the changes, we might want to see whether to only apply it to new events (and maybe old events w/o CSS customization), e.g. by introducing an internal event setting and setting this for any event w/ custom CSS to use the current structure instead. |
|
In general, I don't intend to mess with HTML at all (unless I hit some kind of snag), but anyway I'll be sure to note any changes I make. |
| min-height: 90px; | ||
| text-align: left; | ||
| background: #1a64a0; | ||
| border-top: 3px solid var(--conf-theme-header-border-top); |
There was a problem hiding this comment.
This 3px border looks quite out of place IMHO. It was previously only set in the non-standard themes and the standard.css which is a bit misleading because it's the "you can download this as a starting point" css file which is never used directly by indico.
| /* | ||
| Use this stylesheet to modify the layout of your | ||
| conference. | ||
| */ |
There was a problem hiding this comment.
Considering this, I would replicate all the CSS vars, maybe commented-out, in here.
And also keep commented-out (or empty) CSS rules for the elements that people might want to change beyond just coloring.
There was a problem hiding this comment.
CSS rules for the elements that people might want to change beyond just coloring.
What do you have in mind?
There was a problem hiding this comment.
After looking at it again, maybe just the CSS vars are enough. If people need to do something fancier they can just use devtools to look for the classes...
There was a problem hiding this comment.
Check out the updated version and let me know if that's what you meant.
foxbunny
force-pushed
the
conf-theme-factoring
branch
3 times, most recently
from
3aa8ade to
768ad3e
Compare
| /* Background images */ | ||
| --conf-theme-sprite-image: url(static:images/conf/sprites_blue.png); | ||
|
|
There was a problem hiding this comment.
I'd remove this one here, because special URLs like static:... are not supported in custom CSS
| /* Background images */ | |
| --conf-theme-sprite-image: url(static:images/conf/sprites_blue.png); |
| --conf-theme-header-border-top: #234173; | ||
| --conf-theme-header-border-bottom: #0f4c80; | ||
| --conf-theme-header-text: white; | ||
| --conf-theme-header-border-top-width: 0; |
There was a problem hiding this comment.
I'd move this right before/after --conf-theme-header-border-top since they're related
| --conf-theme-header-border-top: #234173; | ||
| --conf-theme-header-border-bottom: #0f4c80; | ||
| --conf-theme-header-text: white; | ||
| --conf-theme-header-border-top-width: 0; |
There was a problem hiding this comment.
Should this be 3px in brown.css and orange.css? That's what these themes have right now (even though they are very rarely used)...
There was a problem hiding this comment.
Should we take this opportunity to remove those themes? Assuming no recent-ish events use them..
There was a problem hiding this comment.
I think I've seen at least one event using one of them recently... I don't think they provide much value but at the same time there's also no harm nor a significant maintenance burden in having them
ThiefMaster
force-pushed
the
conf-theme-factoring
branch
from
c770a90 to
b6fad2b
Compare
foxbunny
force-pushed
the
conf-theme-factoring
branch
from
aae6ba0 to
da3b0d7
Compare
foxbunny
force-pushed
the
conf-theme-factoring
branch
from
da3b0d7 to
3134647
Compare
It was inconsistent with the default any set to 0 in the latest version of this PR
ThiefMaster
force-pushed
the
conf-theme-factoring
branch
from
3134647 to
a5db568
Compare
3 participants
I was preparing to do some layout changes to do some layout changes to the conference page, but noticed the themes had quite a few overrides and wasn't very clear what the relationship was between them. I cleaned them up using CSS variables. Tried not to change the look of the themes so there's still some overrides here and there that are inconsistent between the themes. Should make theming a lot easier, though.