Expose registration form picture field to the check-in app #7099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Sep 25, 2025
SegiNyn
force-pushed
the
checkin-picture-field
branch
from
4ff0ee0 to
841aa4b
Compare
This was referenced Sep 25, 2025
Also address feedback
Missed this...
ThiefMaster
force-pushed
the
checkin-picture-field
branch
2 times, most recently
from
ca48948 to
2d9f9a0
Compare
It only allows reusing a single method anyway, and does not make the logic easier to understand
ThiefMaster
force-pushed
the
checkin-picture-field
branch
from
2d9f9a0 to
8943f93
Compare
ThiefMaster
approved these changes
Sep 29, 2025
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
Fixed and cleaned up a few things, LGTM now
GovernmentPlates
approved these changes
Sep 29, 2025
tomasr8
reviewed
Sep 29, 2025
indico/modules/events/registration/controllers/api/test_snapshots/checkin_registrations.yml
Show resolved
Hide resolved
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Sep 30, 2025
Co-authored-by: Dominic Hollis <[email protected]> Co-authored-by: Adrian Moennich <[email protected]>
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Sep 30, 2025
Co-authored-by: Dominic Hollis <[email protected]> Co-authored-by: Adrian Moennich <[email protected]>
micsucmed
pushed a commit
to micsucmed/indico
that referenced
this pull request
Oct 3, 2025
Co-authored-by: Dominic Hollis <[email protected]> Co-authored-by: Adrian Moennich <[email protected]>
micsucmed
pushed a commit
to micsucmed/indico
that referenced
this pull request
Oct 3, 2025
Co-authored-by: Dominic Hollis <[email protected]> Co-authored-by: Adrian Moennich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #6506 and I'm opening a new one as I cannot make changes directly in that branch