Skip to content

Improve registrant email validation + logging #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 6 commits into from
Sep 23, 2025
Merged

Improve registrant email validation + logging #7093

ThiefMaster merged 6 commits into from
Sep 23, 2025

Conversation

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Sep 23, 2025 •
edited
Loading

  • Log raw email subject + body before interpolating placeholders
  • Fail validation if a registration/invitation email contains a hardcoded link w/ a registration/invitation token
  • Do not allow sending invitation reminders without the invitation link
  • Log the user who sends an invitation reminder

@ThiefMaster ThiefMaster added this to the v3.3 milestone Sep 23, 2025
@ThiefMaster ThiefMaster marked this pull request as ready for review September 23, 2025 13:16
@ThiefMaster ThiefMaster requested a review from tomasr8 September 23, 2025 13:18
@ThiefMaster ThiefMaster added the build-wheel Build a Python wheel for this PR label Sep 23, 2025
tomasr8
tomasr8 approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just test the no_endpoint_links validator as well though

@ThiefMaster
Copy link
Member Author

ThiefMaster commented Sep 23, 2025

Testing validators is kind of annoying, so I just moved the actual validation logic into an util and added a test for that instead.

@ThiefMaster ThiefMaster merged commit 58bd1f7 into indico:master Sep 23, 2025
10 checks passed
@ThiefMaster ThiefMaster deleted the reg-email-validation branch September 23, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

Assignees

No one assigned

Labels

build-wheel Build a Python wheel for this PR

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@ThiefMaster @tomasr8