Improve dropdown accessibility in category list toolbar #7069
Conversation
foxbunny
force-pushed
the
category-list-toolbar
branch
2 times, most recently
from
4355404 to
8e8d32c
Compare
indico/modules/events/templates/management/_create_event_button.html
Outdated
Show resolved
Hide resolved
foxbunny
force-pushed
the
category-list-toolbar
branch
from
8e8d32c to
24673f6
Compare
ThiefMaster
force-pushed
the
category-list-toolbar
branch
from
24673f6 to
59cd42e
Compare
foxbunny
force-pushed
the
category-list-toolbar
branch
from
59cd42e to
dfc28a8
Compare
foxbunny
changed the title
foxbunny
force-pushed
the
category-list-toolbar
branch
from
dfc28a8 to
5c2b319
Compare
|
@ThiefMaster Have you looked at this yet? Anything else you'd like me to fix/change? |
|
LGTM, just a tiny display issue in case it's easy to fix: The tooltip has some white space between the arrow and the tooltip itself (Firefox) 
I would also be OK with just getting rid of the tooltip there, it's useless IMHO. |
ThiefMaster
force-pushed
the
category-list-toolbar
branch
from
5c2b319 to
1285fdb
Compare
foxbunny
force-pushed
the
category-list-toolbar
branch
from
1285fdb to
88dde6d
Compare
|
I noticed the menu wasn't using the positioning logic and was behaving weird near screen edges so I fixed that. I couldn't reproduce the arrow issue. Can you tell me a bit more about the browser/screen size? I wouldn't remove tooltips from interactive elements that are icon-only. |
foxbunny
force-pushed
the
category-list-toolbar
branch
from
88dde6d to
3c3a02c
Compare
|
This is blocking my current work on the conference contribution filters UI. Let me know if we need further work on this so we can merge it. |
| @include border-all(); | ||
| @include default-border-radius(); | ||
| @include single-box-shadow(); | ||
| background: $light-gray; |
There was a problem hiding this comment.
Removing this breaks most of the existing i-dropdown widgets since they now have transparent background. AFAICT bringing this back has no negative side effects, because all your other changes in this PR use the new dropdown and not the i-dropdown.
So for now I reverted the change to this file (29de195).
2 participants
Before
After