Add SESSION_MAX_LIFETIME setting #7030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a datetime object, which cannot be json-serialized when the multipass_data gets stored in the database.
This never worked, and the original contributor went for a different solution.
ThiefMaster
force-pushed
the
session-max-lifetime
branch
from
c08c829 to
9a8e6be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Indico sessions can be extended indefinitely with activity. This is very user-friendly, but sometimes CSOs don't like this, and prefer that people log in again.
This PR also removes the support for a flask-multipass provider setting such a maximum session lifetime (originally added in #5907). It was broken and thus never used by anyone anyway, since it effectively prevented logging in...