-
Notifications
You must be signed in to change notification settings - Fork 510
Add option to bind registrations to invitation email #6972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58c7f38 to
f4725fd
Compare
ThiefMaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd s/bind/lock/
indico/migrations/versions/20250709_0945_869fb2760b41_add_bind_email_to_invitations.py
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20250709_0945_869fb2760b41_add_bind_email_to_invitations.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/form_submission/selectors.js
Outdated
Show resolved
Hide resolved
f4725fd to
957b908
Compare
680b9ea to
d0b3612
Compare
indico/modules/events/registration/client/js/form_submission/selectors.js
Outdated
Show resolved
Hide resolved
| description=_('If enabled, the user will be able to register even if the event ' | ||
| 'is access-restricted.')) | ||
| lock_email = BooleanField(_('Lock email address'), widget=SwitchWidget(), | ||
| description=_('If enabled, the email address cannot be changed during registration.')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering... if modifications are allowed, then you could simply register with that email and change it afterwards.
Is this a problem? I'm leaning towards "no" because first of all the original person would get a notification and them or the event organizers would probably quickly realize that someone is doing something funny there and remove that registration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess the intention was to prevent ppl mistakenly sharing that link for others to register.. It should still be fine if that person wants to change their email after registering
In form setup mode these items are not in the store, and it's cleaner to have a bool instead of undefined
06034ed to
96f81a7
Compare
| data-initial-values="{{ initial_values | tojson | forceescape }}" | ||
| data-management="{{ management | tojson | forceescape }}" | ||
| data-moderated="{{ moderated | tojson | forceescape }}" | ||
| data-lock-email="{{ invitation.lock_email | tojson | forceescape }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, this broke all registration forms w/o an active invitation. luckily it showed up on the i18n-demo instance first before I put this in production (or in a release) ;)
fixed in 6efb53a
Closes #6803
This PR adds the ability to bind registrations to the email address in the invitation. This is useful for protected events when the invite is set to skip the access check, as well as managed registration forms when the invite is set to skip moderation.