Support custom registration list columns+filters #6968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
reg-custom-list-columns
branch
from
687f7e9 to
0204ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another case that came up related to #6967: Sometimes you just want to include other data in the registrant list for managers or provide filtering, or want to configure whether this extra data should be shown or not.
Using a dummy field for this is obviously a pretty bad idea, so we let plugins extend the registration list generator instead.
...and we should REALLY clean up all this stuff with the ListGenerator, it's really messy and most subclasses (the registration one included) interact w/ the base class in a weird way, instead of having all the standard functionality (static fields, dynamic fields, custom/plugin fields) in the base class and just extending what's needed in the subclass... Probably not something for now but rather when we look into reactifying all these ListGenerator abominations ;)