Allow scanning custom plugin QR codes with the check-in app #6954
Conversation
indico/modules/events/registration/controllers/management/tickets.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/__init__.py
Outdated
Show resolved
Hide resolved
SegiNyn
force-pushed
the
custom-ticket-qr-code
branch
from
6d75b42 to
af59c06
Compare
indico/modules/events/registration/controllers/management/tickets.py
Outdated
Show resolved
Hide resolved
SegiNyn
force-pushed
the
custom-ticket-qr-code
branch
from
efcc560 to
29945c2
Compare
indico/modules/events/registration/controllers/management/tickets.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/tickets.py
Outdated
Show resolved
Hide resolved
| url = config.BASE_URL.removeprefix('https://') | ||
| qr_code_version = 2 | ||
| result = { | ||
| 'i': [qr_code_version, url, _base64_encode_uuid(reg.ticket_uuid)] |
There was a problem hiding this comment.
This does not support handling of custom QR codes tied to accompanying persons... I think the best way to implement this would be to make lookup_registration return not just a registration but also an accompanying person ID (ie a registration, accompanying_id_or_none tuple)
There was a problem hiding this comment.
I didn't include the accompanying person data because I didn't see it being used in the check-in app, https://github.com/indico/indico-checkin-pwa/blob/40e8d3d94f17c0537b4659be9143cac02df5b3cd/src/pages/Auth/utils.ts#L87
Scanning the accompanying person ticket uses the same check-in secret as the registration on the check-in app, unless I missed seeing where it's being used.
There was a problem hiding this comment.
Ah, you're right. We include their ID in the Indico QR code, but apparently we don't do anything special with it in the app.
SegiNyn
force-pushed
the
custom-ticket-qr-code
branch
2 times, most recently
from
1ccbfe7 to
e4577f2
Compare
ThiefMaster
force-pushed
the
custom-ticket-qr-code
branch
from
e4577f2 to
777ee10
Compare
ThiefMaster
force-pushed
the
custom-ticket-qr-code
branch
from
d953811 to
7f2c94c
Compare
ThiefMaster
force-pushed
the
custom-ticket-qr-code
branch
from
7f2c94c to
44b12e2
Compare
3 participants
This PR is to allow scanning custom plugin qr-codes using the check-in app.
Associated PR: indico/indico-checkin-pwa#87