Add text overflow option in badge designer #6944
Conversation
SegiNyn
force-pushed
the
resize-text-in-designer
branch
from
e732ba9 to
dad10ab
Compare
| let fontSize = item.font_size; | ||
| fontSize = parseFloat(pattern.exec(fontSize)[1]); |
There was a problem hiding this comment.
| let fontSize = item.font_size; | |
| fontSize = parseFloat(pattern.exec(fontSize)[1]); | |
| let fontSize = parseFloat(pattern.exec(item.font_size)[1]); |
|
Is the ellipsis option going to be useful for badges? It seems no better than truncating. Maybe just wrap and resize is enough? |
I added the ellipsis since this was a setting so we could add different options but I can remove it if no one thinks it's useful. I didn't understand "seems no better than truncating" as there is no truncating option. |
SegiNyn
force-pushed
the
resize-text-in-designer
branch
from
501ee52 to
27ed8d0
Compare
|
Ah I thought truncating was the default, disregard my comment :) I'd only add the resize option (and keep the wrap option) unless someone needs the ellipsis as well. |
|
The ellipsis option has been removed. |
indico/modules/designer/pdf.py
Outdated
| return color | ||
|
|
||
| def _get_resized_font(self, content, font_size, font_name, width): | ||
| min_font_size = 4 |
There was a problem hiding this comment.
I gave it a try and 4 is pretty much unreadable. What about using 6 as the minimum?
There was a problem hiding this comment.
In fact the minimum selectable size in the badge editor is 7. I don't have a strong opinion on whether to go for 6 or 7 as the minimum though. But maybe when going for 6, it shouldalso be the smallest selectable size?
There was a problem hiding this comment.
ok, I went with 6 as the minimum.
SegiNyn
force-pushed
the
resize-text-in-designer
branch
from
6184aea to
ac0aa86
Compare
ThiefMaster
force-pushed
the
resize-text-in-designer
branch
from
ac0aa86 to
a349e95
Compare
3 participants
This PR adds an option in the badge designer for dealing with overflowing text: To either wrap (already the default), resize or add ellipsis to the text.
E.g Given this badge design:
Changing the text_overflow option for the "Event Title" and "Fixed text" as example, the resulting badge should look like:
Wrap option:
Resize option:
