Allow resending emails from event logs #6909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Jun 2, 2025
ThiefMaster
reviewed
Jun 4, 2025
duartegalvao
force-pushed
the
resend-emails
branch
from
ca4d8ea to
83b366c
Compare
ThiefMaster
reviewed
Jun 5, 2025
duartegalvao
force-pushed
the
resend-emails
branch
from
83b366c to
09f5cf2
Compare
tomasr8
reviewed
Jun 12, 2025
duartegalvao
force-pushed
the
resend-emails
branch
from
09f5cf2 to
b517aeb
Compare
GovernmentPlates
approved these changes
Jun 19, 2025
ThiefMaster
reviewed
Jun 19, 2025
- show disabled reason as tooltip - s/resend/re-send/ - missing i18n - remove unnecessary event from locator
ThiefMaster
force-pushed
the
resend-emails
branch
from
b517aeb to
54f7d5d
Compare
ThiefMaster
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6805
This PR adds a button for resending emails from log entries:
It also adds the attachment count to the log details. Emails with attachments are not supported, since we don't store the files:
Resending is also disabled while emails are pending.
The following is added to the log metadata, for future use:
resent: boolean, whether the email has been resentfrom_log_entry_id: number, entry ID for the original email log entryIt would be nice to have a link in the details to open the original log entry. However this is currently complicated since the navigation is done in React but the details page itself is generated from a Jinja template. Perhaps a button could be added to the bottom nav bar.