Fix PDF timetable color and AM/PM toggle #6888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 12, 2025
ThiefMaster
reviewed
May 12, 2025
AjobK
force-pushed
the
pdf-timetable-fixes
branch
from
65250cd to
82f538e
Compare
tomasr8
reviewed
May 15, 2025
AjobK
force-pushed
the
pdf-timetable-fixes
branch
from
82f538e to
c959a8b
Compare
ThiefMaster
reviewed
Jun 26, 2025
Member
|
Can you add a changelog entry? LGTM otherwise |
ThiefMaster
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Indico Workshop 2025 two issues regarding the PDF timetable were mentioned.
Extra context:
It seems like babel does not adjust the time to AM/PM based on locale. Formatting time does, but specifically the
format_intervalfunction does not. However, this is more related to the Unicode markup ruleset in babel.https://unicode.org/reports/tr35/tr35-dates.html#element-intervalformats
For now it is toggled manually, however in the future it might be something worth addressing with babel itself.