Skip to content

Fix clearing title of event persons #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 1 commit into from
Apr 23, 2025
Merged

Fix clearing title of event persons #6859

ThiefMaster merged 1 commit into from
Apr 23, 2025

Conversation

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Apr 23, 2025

  • Send null instead of "" when there's no title - this also matches the initial data
  • Use the correct field that translates between None and the no title enum value

@ThiefMaster ThiefMaster added this to the v3.3 milestone Apr 23, 2025
@ThiefMaster ThiefMaster requested a review from tomasr8 April 23, 2025 13:17
@ThiefMaster ThiefMaster added the build-wheel Build a Python wheel for this PR label Apr 23, 2025
@ThiefMaster ThiefMaster merged commit d9ab6ed into indico:master Apr 23, 2025
11 checks passed
@ThiefMaster ThiefMaster deleted the clear-title branch April 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 Awaiting requested review from tomasr8

Assignees

No one assigned

Labels

build-wheel Build a Python wheel for this PR

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

1 participant

@ThiefMaster