-
Notifications
You must be signed in to change notification settings - Fork 510
Fix issue with select/combobox on iOS Safari #6839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc554c5 to
601d74a
Compare
601d74a to
10cf1bf
Compare
|
Seems to work fine as far as I can tell on the iPad we have here! Only slightly weird thing I noticed is that the open dropdown only repositions itself when you scroll until you finished scrolling... not sure how often people actually scroll the page w/ a dropdown open though. |
|
Yeah, I couldn't find a workaround for that. The elastic scroll isn't taken into account when the browser reports scrollY. |
|
My colleague with an iphone tested this and the country field works now, but in single-choice registration fields it often simply doesn't select an option when tapping it in the dropdown |
|
Could you please ask them what version of iOS they're on? I've specifically fixed that on the BrowserStack iPad... |
|
FWIW on the iPad we have here it also did not happen, but for @GovernmentPlates this also happened on the emulator (emulated iphone, not ipad) |
|
At least his UA string was "Mozilla/5.0 (iPhone; CPU iPhone OS 18_3_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.3.1 Mobile/15E148 Safari/604.1" |
|
My phone is using iOS 18.3.2 |
|
Thanks |
2e59cf5 to
692e02b
Compare
- Fix unresponsive selection by tap - Fix buggy positioning logic See additional notes in positioning.js for more details on how the fix works. Fixes indico#6830
Also adds a remote logger for emergency use
It may be useful, but does not belong in this PR
692e02b to
ce88858
Compare
See additional notes in positioning.js for more details on how the fix works.
Fixes #6830