Skip to content

Use new DatePicker in WTForms date/time fields #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 22 commits into from
Apr 7, 2025
Merged

Use new DatePicker in WTForms date/time fields #6832

ThiefMaster merged 22 commits into from
Apr 7, 2025

Conversation

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Apr 3, 2025 •
edited
Loading

closes #6662

@ThiefMaster ThiefMaster added this to the v3.3 milestone Apr 3, 2025
tomasr8
tomasr8 reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon alignment/size seems a bit off in the cloning dialog:
image

Compare with the material package form:
image

ThiefMaster
ThiefMaster commented Apr 3, 2025
View reviewed changes
indico/web/client/js/custom_elements/ind_date_picker.scss
}
}

.ui-widget ind-date-picker > button {
Copy link
Member Author

@ThiefMaster ThiefMaster Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foxbunny Do you see a better solution for this? Making the rule inside %text-size-reset important would also work, but not sure if this doesn't have some bad side effects elsewhere...

Copy link
Collaborator

@foxbunny foxbunny Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%text-size-reset is probably not the best workaround for the font size issue. It's more like a marker so I know what to address once we actually solve the problem (god knows when, lol). In theory, it shouldn't have any bad side-effects, but it can fail to work when, say, there are rules with high-specificity selectors that affect elements inside the widget and override font sizes.

@ThiefMaster ThiefMaster marked this pull request as ready for review April 3, 2025 15:13
@ThiefMaster ThiefMaster mentioned this pull request Apr 3, 2025
Merged
ThiefMaster and others added 11 commits April 4, 2025 11:43
tomasr8
tomasr8 approved these changes Apr 4, 2025
View reviewed changes
@ThiefMaster ThiefMaster changed the title Use new DatePicker in WTForms IndicoDateField Use new DatePicker in WTForms date/time fields Apr 7, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Apr 7, 2025
@ThiefMaster ThiefMaster merged commit 4ef6c89 into indico:master Apr 7, 2025
10 checks passed
@ThiefMaster ThiefMaster deleted the wtf-date-picker branch April 7, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

+1 more reviewer

@foxbunny foxbunny foxbunny left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

Ensure the new DatePicker can be used in WTFDateField etc.

3 participants

@ThiefMaster @foxbunny @tomasr8