Add "allowed keywords" for contributions #6778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I would put it on the same page (ie a single form), and put the settings for both in the same global_event_settings = SettingsProxy('events', {
'allowed_keywords': [],
+ 'allowed_contribution_keywords': [],
})Having it in an "[event_]keywords" SettingsProxy would be even nicer, but that would require an alembic revision to rename the existing setting... |
tomako
force-pushed
the
contribution_keywords
branch
from
d7d5846 to
b7c37f5
Compare
Contributor
Author
|
tomako
force-pushed
the
contribution_keywords
branch
2 times, most recently
from
f851661 to
afa1d13
Compare
ThiefMaster
force-pushed
the
contribution_keywords
branch
from
afa1d13 to
561024a
Compare
ThiefMaster
approved these changes
Mar 20, 2025
Member
|
/cc @alittle60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding "allowed keywords" for contributions. The same feature we already have for events.
A new menu item "Contribution Keywords" is added to Administration/Customization.
We had an internal discussion about whether it would be better to merge "Event Keywords" and "Contribution Keywords" into one page as "Allowed Keywords" and let manage all on the same place. We had no strong standpoint for either solution. Eventually I kept them separately because I thought it's slightly easier to find it. Please let me know what do you think.