Select All button for room list #6773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
suggested changes
Feb 25, 2025
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
475cbfe to
bb52b07
Compare
tomasr8
reviewed
Feb 26, 2025
tomasr8
reviewed
Feb 26, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
3ae1757 to
9a6e959
Compare
github-actions
bot
added
dependencies
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
9a6e959 to
52a4fb2
Compare
github-actions
bot
removed
dependencies
Member
|
Works fine and looks nice :) Just one thought: should we really show this option when you select rooms for blocking? If someone uses this and requests a blocking for 100 rooms, it will be very annoying since they spam every room owner with it... To me it seems useful for export, but not for blocking. |
This comment was marked as resolved.
This comment was marked as resolved.
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
02b446b to
191834d
Compare
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
02c0bdd to
df6d8d4
Compare
GovernmentPlates
approved these changes
Mar 4, 2025
Michi03
force-pushed
the
rb-export-select-all-btn
branch
from
df6d8d4 to
d6298dd
Compare
ThiefMaster
force-pushed
the
rb-export-select-all-btn
branch
from
d6298dd to
c65ef6d
Compare
ThiefMaster
force-pushed
the
rb-export-select-all-btn
branch
from
c65ef6d to
90ad517
Compare
ThiefMaster
force-pushed
the
rb-export-select-all-btn
branch
from
90ad517 to
b58bd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the RoomList module when the a selectionMode is set. If all of the rooms currently listed are selected the button unselects them. Else, all listed rooms are selected.