Hide default value data in purged regform fields #6772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task to purge registration field data beyond retention period overwrites the field data with the field's default value. See https://github.com/indico/indico/blob/e9e4daab682c1d93cde575d3446fed265427da72/indico/modules/events/registration/tasks.py#L63-L67 for rationale. Check if field is purged before trying to render its value in registration details.
ThiefMaster
force-pushed
the
fix-5898
branch
from
4094dd4 to
e619470
Compare
ThiefMaster
approved these changes
Feb 24, 2025
Member
|
I just noticed that we should do the same in the table listing all the registrations. For example, for an accommodation field that has been purged, it currently looks like this:
which is the "falsy" default value for this field type. |
amCap1712
added a commit
to amCap1712/indico
that referenced
this pull request
Feb 28, 2025
Implemented the same changes as indico#6772 but for registrations list table on manage registrations page.
amCap1712
added a commit
to amCap1712/indico
that referenced
this pull request
Feb 28, 2025
Implemented the same changes as indico#6772 but for registrations list table on manage registrations page.
ThiefMaster
pushed a commit
to amCap1712/indico
that referenced
this pull request
Mar 19, 2025
Implemented the same changes as indico#6772 but for registrations list table on manage registrations page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task to purge registration field data beyond retention period overwrites the field data with the field's default value.
indico/indico/modules/events/registration/tasks.py
Lines 63 to 67 in e9e4daa
Check if field is purged before trying to render its value in registration details to avoid displaying such data to the user.
Before:
After:
Fixes #5898