Skip to content

Improve places selection accessibility in SingleChoiceInput #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 1 commit into from
Feb 20, 2025
Merged

Improve places selection accessibility in SingleChoiceInput #6763

ThiefMaster merged 1 commit into from
Feb 20, 2025

Conversation

@foxbunny
Copy link
Collaborator

@foxbunny foxbunny commented Feb 20, 2025

  • Use Select instead of Dropdown

@foxbunny foxbunny force-pushed the single-choice-price-dropdown branch from 1c49cdc to 2db42c8 Compare February 20, 2025 03:34
@foxbunny foxbunny added the a11y label Feb 20, 2025
@foxbunny foxbunny requested a review from ThiefMaster February 20, 2025 03:34
@foxbunny foxbunny force-pushed the single-choice-price-dropdown branch from 2db42c8 to 7273979 Compare February 20, 2025 03:35
ThiefMaster
ThiefMaster reviewed Feb 20, 2025
View reviewed changes
ThiefMaster
ThiefMaster approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine :)

@ThiefMaster ThiefMaster merged commit 89541eb into indico:master Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

a11y

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@foxbunny @ThiefMaster