Refactor: Prevent service request notifications when deleting past events #6754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Feb 17, 2025
Member
|
Hey, while testing this I noticed that unfortunately adding the new arg to While this would have been doable (I doubt anyone besides us has plugins implementing service requests with custom actions during withdraw), it still feels a bit unclean. Because of this I changed your PR a bit to simply not trigger withdrawal notifications at all if the event has finished. (I'll keep you credited for the contribution nonetheless, since you could not have known this, and even I only realized this during testing.) |
ThiefMaster
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6700
Checks if start date is prior to current date and then uses a flag to change notify logic
Added a new parameter associated with past events in