Log changes to event payment methods #6739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
approved these changes
Feb 10, 2025
| self.plugin.event_settings.set_multi(self.event, form.data) | ||
| match plugin_event_settings.get('enabled'), form.enabled.data: | ||
| case True, False: | ||
| self.event.log(EventLogRealm.management, LogKind.negative, 'Payment', |
Member
There was a problem hiding this comment.
Maybe at some point the module names could become an enum as well?
Member
Author
There was a problem hiding this comment.
Not sure, we have MANY different ones... I guess we could use an enum for the string, but I would not store it as an enum in the DB, since that'd make adding new ones a bit of a pain.
It would also not be particularly plugin-friendly if using an enum was required :)
Member
There was a problem hiding this comment.
I suggested an enum just to avoid accidentally creating similar-but-different categories like Payment and Payments, I wouldn't want to enforce it at the DB-level but just to make it easier for us to know what categories already exist :)
ThiefMaster
force-pushed
the
log-payment-config
branch
2 times, most recently
from
ab886bc to
08d1a28
Compare
ThiefMaster
force-pushed
the
log-payment-config
branch
from
08d1a28 to
d0dab54
Compare
ThiefMaster
force-pushed
the
log-payment-config
branch
from
d0dab54 to
adb9c33
Compare
ThiefMaster
force-pushed
the
log-payment-config
branch
from
adb9c33 to
91b1a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this logs all changes, since a diff log would be hard since most options are provided by the payment plugin and not known to the core.
I might change it to at least skip the
enabledflag and only log things that actually changed...